Support global opts related to server timeouts #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzottola
changed the title
ehuss
reviewed
May 18, 2024
src/opts.rs
Outdated
| raw::GIT_OPT_GET_SERVER_CONNECT_TIMEOUT as libc::c_int, | ||
| &mut server_connect_timeout | ||
| )); | ||
| println!("result = {}", server_connect_timeout); |
Contributor
There was a problem hiding this comment.
Looks like maybe a stray debug?
Contributor
Author
There was a problem hiding this comment.
My bad 🤦, thanks !
Contributor
|
@mzottola It looks like this has some merge conflicts, can you rebase this? |
Contributor
Author
|
@ehuss Understood for next time 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We would like to apply some timeouts during git operations i.e git clone
The libgit2 provides 2 global options for that:
GIT_OPT_SET_SERVER_CONNECT_TIMEOUTGIT_OPT_SET_SERVER_TIMEOUTThe purpose of this PR is to add the support for those options (along with their getters)
The link to libgit2 details: https://github.com/libgit2/libgit2/blob/main/include/git2/common.h#L508C38-L524